Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wetting model for CSF Surface Tension Models #666

Draft
wants to merge 658 commits into
base: main
Choose a base branch
from

Conversation

svchb
Copy link
Collaborator

@svchb svchb commented Nov 14, 2024

Depends on #664
Depends on #498
Depends on #539
Depends on #604
Depends on #605
Depends on #606
Depends on #607
Depends on #608
Depends on #609
Depends on #599
Depends on #584

@svchb svchb marked this pull request as draft November 14, 2024 14:11
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 44.85597% with 268 lines in your changes missing coverage. Please review.

Project coverage is 66.77%. Comparing base (231e2e0) to head (f61c380).

Files with missing lines Patch % Lines
src/schemes/fluid/surface_normal_sph.jl 24.25% 153 Missing ⚠️
src/visualization/write2vtk.jl 0.00% 31 Missing ⚠️
src/schemes/fluid/surface_tension.jl 11.76% 30 Missing ⚠️
src/schemes/boundary/system.jl 57.14% 15 Missing ⚠️
src/schemes/fluid/fluid.jl 33.33% 12 Missing ⚠️
...rc/schemes/fluid/entropically_damped_sph/system.jl 50.00% 10 Missing ⚠️
...rc/schemes/fluid/weakly_compressible_sph/system.jl 72.72% 6 Missing ⚠️
src/general/semidiscretization.jl 72.22% 5 Missing ⚠️
src/general/system.jl 33.33% 4 Missing ⚠️
src/schemes/boundary/boundary.jl 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #666      +/-   ##
==========================================
- Coverage   68.54%   66.77%   -1.78%     
==========================================
  Files          87       90       +3     
  Lines        5389     5796     +407     
==========================================
+ Hits         3694     3870     +176     
- Misses       1695     1926     +231     
Flag Coverage Δ
unit 66.77% <44.85%> (-1.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant